-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(string family): implement cl.throttle
#714
Conversation
I did not add any new integer overflow checks, but i think they should be. |
I think i've applied all the suggestions. Tell me what should i also do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, much better. Have a few minor comments.
I think after the next pass, we will submit it.
Please use pre-commit checks to verify formatting. |
Also add one test when `count == 0`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for contributing this feature, @zetanumbers !
Thank you for helping me figure out how to do it. |
Solves #270