Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(string family): implement cl.throttle #714

Merged
merged 10 commits into from
Jan 24, 2023

Conversation

zetanumbers
Copy link
Contributor

@zetanumbers zetanumbers commented Jan 20, 2023

Solves #270

  • Port all of the tests;
  • Integer overflow safety.

@zetanumbers
Copy link
Contributor Author

I did not add any new integer overflow checks, but i think they should be.

src/server/string_family.cc Show resolved Hide resolved
src/server/string_family.cc Show resolved Hide resolved
src/server/string_family.cc Show resolved Hide resolved
src/server/string_family.cc Outdated Show resolved Hide resolved
src/server/string_family.cc Show resolved Hide resolved
src/server/string_family.cc Outdated Show resolved Hide resolved
src/server/string_family.cc Outdated Show resolved Hide resolved
src/server/string_family.cc Outdated Show resolved Hide resolved
@zetanumbers
Copy link
Contributor Author

I think i've applied all the suggestions. Tell me what should i also do.

Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much better. Have a few minor comments.
I think after the next pass, we will submit it.

src/server/string_family.cc Outdated Show resolved Hide resolved
src/server/string_family.cc Outdated Show resolved Hide resolved
src/server/string_family.cc Show resolved Hide resolved
@romange
Copy link
Collaborator

romange commented Jan 23, 2023

Please use pre-commit checks to verify formatting.
See here on how to install them: https://github.com/dragonflydb/dragonfly/blob/main/CONTRIBUTING.md#before-you-make-your-changes

@zetanumbers zetanumbers requested a review from romange January 24, 2023 12:01
Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for contributing this feature, @zetanumbers !

@romange romange merged commit b1b25d0 into dragonflydb:main Jan 24, 2023
@zetanumbers zetanumbers deleted the throttle branch January 24, 2023 12:55
@zetanumbers
Copy link
Contributor Author

Thank you for helping me figure out how to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants