fix(server): Reset interpreter stack on errors #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add unit test |
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
fix-interpreter
branch
from
cf9c2b0 to
971f397
Compare
dranikpg
commented
Feb 2, 2023
Comment on lines
+904
to
+907
| for (int i = 0; i < 3'000; i++) { | ||
| Run({"EVAL", "redis.get(KEYS[1], KEYS[2], KEYS[3], KEYS[4], KEYS[5])", "5", "k1", "k2", "k3", | ||
| "k4", "k5"}); | ||
| } |
There was a problem hiding this comment.
I experimentally determined this is the min amount to make it fail. We need to pollute the stack largely enough
romange
approved these changes
Feb 2, 2023
ashotland
pushed a commit
that referenced
this pull request
Feb 2, 2023
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #742