feat(server): Pool lua interpreters #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
commented
Feb 8, 2023
src/server/common.cc
Outdated
Comment on lines
30
to
31
| ABSL_FLAG(uint32_t, interpreter_per_thread, 5, "Lua interpreters per thread"); | ||
|
|
There was a problem hiding this comment.
its strange common.cc is responsible for initializing server state 🤨
There was a problem hiding this comment.
I agree. pull it out in another pr
There was a problem hiding this comment.
We can also increase it to about 10-15, above it usually delivers only small gains (given that most scripts are most likely a few ops), but I'm not sure why to keep the values low, if the interpreter overhead is likely super small
romange
previously approved these changes
Feb 8, 2023
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
romange
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #741