fix(server): monitor lua at script execution #767

boazsade · 2023-02-08T13:50:12Z

Signed-off-by: Boaz Sade boaz@dragonflydb.io
fixes issue #756

Move the report of the command so that we will see it even if there are issues with the command execution.
Add test to reproduce the issue as part of the integration tests.

tests/dragonfly/connection_test.py

src/server/main_service.cc

Signed-off-by: Boaz Sade <boaz@dragonflydb.io>

boazsade requested a review from dranikpg February 9, 2023 08:02

dranikpg previously approved these changes Feb 9, 2023

View reviewed changes

romange force-pushed the main branch from 2362e55 to 8383753 Compare February 10, 2023 20:37

romange reviewed Feb 12, 2023

View reviewed changes

tests/dragonfly/connection_test.py Outdated Show resolved Hide resolved

romange reviewed Feb 12, 2023

View reviewed changes

src/server/main_service.cc Show resolved Hide resolved

boazsade dismissed dranikpg’s stale review via 5ce5422 February 12, 2023 07:05

boazsade force-pushed the monitor-lua-issue branch from fccf363 to 5ce5422 Compare February 12, 2023 07:05

romange previously approved these changes Feb 12, 2023

View reviewed changes

fix(server): monitor lua at script execution

933a86a

Signed-off-by: Boaz Sade <boaz@dragonflydb.io>

boazsade dismissed romange’s stale review via 933a86a February 12, 2023 15:18

boazsade force-pushed the monitor-lua-issue branch from 5ce5422 to 933a86a Compare February 12, 2023 15:18

romange approved these changes Feb 12, 2023

View reviewed changes

boazsade merged commit e7a5d58 into dragonflydb:main Feb 12, 2023

Provide feedback