Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): track pipeline requests cache capacity #776

Merged
merged 1 commit into from
Feb 12, 2023
Merged

feat(server): track pipeline requests cache capacity #776

merged 1 commit into from
Feb 12, 2023

Conversation

romange
Copy link
Collaborator

@romange romange commented Feb 11, 2023

  1. now pipeline_cache_capacity tracks how many bytes are allocated via free_req_pool_ cache. it's been shown now via "pipeline_cache_bytes" stat in "info memory" command.
  2. a small refactoring of server_state code into server_code.cc

Signed-off-by: Roman Gershman roman@dragonflydb.io

@romange romange requested a review from dranikpg February 11, 2023 06:41
dranikpg
dranikpg previously approved these changes Feb 11, 2023
@@ -48,4 +59,31 @@ void MonitorsRepo::NotifyChangeCount(bool added) {
}
}

ServerState::ServerState() : interpreter_mgr_{absl::GetFlag(FLAGS_interpreter_per_thread)} {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

1. now pipeline_cache_capacity tracks how many bytes are allocated via free_req_pool_ cache.
   it's been shown now via "pipeline_cache_bytes" stat in "info memory" command.
2. a small refactoring of server_state code into server_state.cc
3. Reduce dependency of dfly_transaction on facade lib.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
@romange romange merged commit 6f1e491 into main Feb 12, 2023
@romange romange deleted the Pr2 branch February 12, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants