Refactor initialization phase of transaction #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
refactor-tx-init
branch
from
ecd24c3 to
9de9615
Compare
romange
reviewed
Feb 13, 2023
src/server/transaction.cc
Outdated
| /** | ||
| * | ||
| * There are 4 options that we consider here: | ||
| * a. T spans a single shard and its not multi. |
There was a problem hiding this comment.
use consistent notion for transaction: for example, Tx instead of T and Trans
There was a problem hiding this comment.
I didn't touch you comments at all yet
There was a problem hiding this comment.
oh, I thought their are yours. in that case the comments are perfect 🙃
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
romange
reviewed
Feb 13, 2023
|
There are no functional changes in this PR, except that we have a new |
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
romange
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InitByArgs is 200+ LOC and I need to extend it to support different multi-transaction modes, so I decided to refactor it a little, else it'll become an unmanageable mess
I've split it into multiple commits, each of them encompasses one or two changes