feat(server): save dragonfly snapshot in a new format by default #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new flag `df_snapshot_format` that controls the default behavior. The flag itself is defaulted to save snapshots in a new Dragonfly specific format. BREAKING CHANGE: before that Dragonfly saved snapshots in rdb format by default. Now the flag controls which format is chosen when issuing SAVE/BGSAVE commands. In addition, "SAVE DF", "SAVE RDB" can be used to save using dragonfly/redis formats accordingly. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
dranikpg
approved these changes
Feb 14, 2023
Comment on lines
+59
to
+60
| ABSL_FLAG(bool, df_snapshot_format, true, | ||
| "if true, save in dragonfly-specific snapshotting format"); |
There was a problem hiding this comment.
the name is a bit misleading for a bool flag if you interpret df_ as a prefix, not the type of the format
|
How you suggest to name it?
…On Tue, Feb 14, 2023, 23:21 Vladislav ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In src/server/server_family.cc
<#802 (comment)>
:
> +ABSL_FLAG(bool, df_snapshot_format, true,
+ "if true, save in dragonfly-specific snapshotting format");
the name is a bit misleading for a bool flag if you interpret df_ as a
prefix, not the type of the format
—
Reply to this email directly, view it on GitHub
<#802 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4BFCDJ7INRH7MZ3HW36HLWXPZMHANCNFSM6AAAAAAU3ZAFAE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Maybe enable_df_format... I also not against keeping the current one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new flag
df_snapshot_formatthat controls the default behavior. The flag itself is defaulted to save snapshots in a new Dragonfly specific format.BREAKING CHANGE: before that Dragonfly saved snapshots in rdb format by default. Now the flag controls which format is chosen when issuing SAVE/BGSAVE commands. In addition, "SAVE DF", "SAVE RDB" can be used to save using dragonfly/redis formats accordingly.
Signed-off-by: Roman Gershman roman@dragonflydb.io