Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pytest): fix periodic test #804

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Conversation

dranikpg
Copy link
Contributor

@dranikpg dranikpg commented Feb 15, 2023

Now it should run

Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
@dranikpg dranikpg requested a review from adiholden February 15, 2023 09:01
Comment on lines -83 to +84
assert (self.tmp_dir / "test-periodic.rdb").exists()
files = [f for f in os.listdir(self.tmp_dir) if f.startswith('test-periodic')]
assert len(files) > 0 and any(f.endswith('summary.dfs') for f in files)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a bug here, that even with the extension, the timestamp is still included

But its not connected with making the pytest run

@adiholden adiholden merged commit 83256bd into dragonflydb:main Feb 15, 2023
@dranikpg dranikpg deleted the fix-pytest branch February 27, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants