feat(server): add debug information about running transactions #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
reviewed
Feb 19, 2023
src/server/debugcmd.cc
Outdated
| Transaction* trx = std::get<Transaction*>(value); | ||
|
|
||
| IntentLock::Mode mode = trx->Mode(); | ||
| KeyLockArgs lock_args = trx->GetLockArgs(sid); |
There was a problem hiding this comment.
GetLockArgs() returns the lock args for the current command. For a multi tx the current command is only the command that is currently executing.
So I guess a possible flow for multi commands is:
tx->StartMulti(all_keys); // this is where schedule happens
tx->SwitchMultiCmd();
tx->InitByArgs(ars_with_one_key); // but it was scheduled on a lot of keys
// inside cmd
tx->ScheduleSingleHop(); // thats where its blocked, and thats where you look at it, but its has data only for cmdWith LOCK_AHEAD mode, the only place this locking information is stored is inside MultiData. So you need one more helper function - scheduled keys - that'll return this info for multi and plain shard args for regular commands
dranikpg
previously approved these changes
Feb 19, 2023
Specifically, provide a total length over all shards of pending txs. Also, provide number of "free" transactions pending in the queue - those that could progress immediately but do not because they are not first in the queue. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
force-pushed
the
EstimateTxLength
branch
from
30c351e to
731c7a4
Compare
dranikpg
approved these changes
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, provide a total length over all shards of pending txs. Also, provide number of "free" transactions pending in the queue - those that could progress immediately but do not because they are not first in the queue.