Add basic replicaiton from redis test #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashotland <ari@dragonflydb.io>
ashotland
force-pushed
the
redis-replication
branch
from
50568be to
82c13e8
Compare
ashotland
commented
Mar 1, 2023
| self.proc = None | ||
|
|
||
| def start(self): | ||
| self.proc = subprocess.Popen(["redis-server-6.2.11", |
There was a problem hiding this comment.
Added this binary to the image used for the github actions regression tests
dranikpg
approved these changes
Mar 1, 2023
Comment on lines
+74
to
+75
| seeder = df_seeder_factory.create(port=redis_server.port, keys=100, dbcount=1, unsupported_types=[ValueType.JSON]) | ||
| await seeder.run(target_ops=100) |
There was a problem hiding this comment.
I would maybe make the values a big larger (multiple dbs, more keys), I assume it takes no more than a few seconds
There was a problem hiding this comment.
I'll follow up with more complex cases - just wanted to the establish something to start with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.