fix: correctly set batching mode during pubsub #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we set batch mode when dispatch queue is not empty but dispatch queue could contain other async messages related to pubsub or monitor. Now we enable batching only if there are more pipeline commands in the queue. In addition, fix the issue of unlimited aggregation of batching buffer. Fixes #935. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
force-pushed
the
FixPubsubPipeline
branch
from
1b9b286 to
793092d
Compare
dranikpg
approved these changes
Mar 14, 2023
Comment on lines
+55
to
+61
| if (total_size < 8192) { // Allow batching with up to 8K of data. | ||
| for (unsigned i = 0; i < len; ++i) { | ||
| std::string_view src((char*)v[i].iov_base, v[i].iov_len); | ||
| DVLOG(2) << "Appending to stream " << src; | ||
| batch_.append(src.data(), src.size()); | ||
| } | ||
| return; |
There was a problem hiding this comment.
I'd maybe move this magic number to a constant somewhere
There was a problem hiding this comment.
will do in the next pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we set batch mode when dispatch queue is not empty but dispatch queue could contain other async messages related to pubsub or monitor. Now we enable batching only if there are more pipeline commands in the queue.
Fixes #935.