fix(docker): Use the right shebang in healthcheck.sh
#963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alpine images don't have bash installed by default, so we need to use `/bin/sh` instead. This follows the *same existing convention that we follow in the `entrypoint.sh` script*. Both ubuntu and alpine images have been tested (i.e healthchecks to pass) to work with this change.
romange
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #942
Alpine images don't have bash installed by default, so we need to use
/bin/shinstead. This follows the same existing convention thatwe follow in the
entrypoint.shscript.Both ubuntu and alpine images have been tested (i.e healthchecks to
pass) to work with this change.
Testing
Build the new image
docker build -f ./tools/docker/Dockerfile.alpine-dev . -t ghcr.io/pothulapati/dfRun and Verify
docker run --network=host --ulimit memlock=-1 ghcr.io/pothulapati/df & docker ps