feat: add authinfo injector #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2149 +/- ##
==========================================
- Coverage 47.48% 47.39% -0.10%
==========================================
Files 141 141
Lines 19329 19354 +25
==========================================
- Hits 9178 9172 -6
- Misses 9560 9590 +30
- Partials 591 592 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: Jim Ma <majinjing3@gmail.com>
MIchaelFU0403
pushed a commit
to MIchaelFU0403/Dragonfly2
that referenced
this pull request
Mar 31, 2023
Signed-off-by: Jim Ma <majinjing3@gmail.com> Signed-off-by: MIchaelFU0403 <1078537664@qq.com>
lilongfeng0902
pushed a commit
to lilongfeng0902/Dragonfly2
that referenced
this pull request
May 15, 2023
Signed-off-by: Jim Ma <majinjing3@gmail.com> Signed-off-by: 李龙峰 <lilongfeng@inspur.com>
gaius-qi
pushed a commit
that referenced
this pull request
Jun 28, 2023
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When download with dfget, some config like docker config is in special user's home directory.
For more flexible to fetch auth information, we introduce a new interface
AuthInfoInjector.Source client can register
AuthInfoInjectoroptional.AuthInfoInjectorwill be invoked before dfget send the download grpc request to daemon.AuthInfoInjectorinjects auth information into the urlMeta or others.Related Issue
#2146
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist