Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add trainer configuration #2216

Merged
merged 6 commits into from
Apr 3, 2023
Merged

Conversation

MIchaelFU0403
Copy link
Contributor

@MIchaelFU0403 MIchaelFU0403 commented Mar 24, 2023

Add trainer configuration

Description

Trainer is designed for training machine learning and ai models that support schedulers to make scheduling decision for each peer task.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@MIchaelFU0403 MIchaelFU0403 requested a review from a team as a code owner March 24, 2023 05:30
@gaius-qi gaius-qi added the enhancement New feature or request label Mar 24, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone Mar 24, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #2216 (90afcf0) into main (bcd992e) will increase coverage by 0.14%.
The diff coverage is 92.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2216      +/-   ##
==========================================
+ Coverage   49.47%   49.62%   +0.14%     
==========================================
  Files         145      146       +1     
  Lines       19429    19505      +76     
==========================================
+ Hits         9613     9679      +66     
- Misses       9224     9230       +6     
- Partials      592      596       +4     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.62% <92.10%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
trainer/config/config.go 92.10% <92.10%> (ø)

... and 2 files with indirect coverage changes

trainer/config/config.go Outdated Show resolved Hide resolved
trainer/config/config.go Outdated Show resolved Hide resolved
trainer/config/config.go Outdated Show resolved Hide resolved
trainer/config/constants.go Outdated Show resolved Hide resolved
trainer/config/config.go Outdated Show resolved Hide resolved
trainer/config/config.go Outdated Show resolved Hide resolved
trainer/config/config.go Outdated Show resolved Hide resolved
trainer/config/config.go Outdated Show resolved Hide resolved
trainer/config/config.go Outdated Show resolved Hide resolved
Signed-off-by: MIchaelFU0403 <1078537664@qq.com>
@MIchaelFU0403 MIchaelFU0403 reopened this Mar 31, 2023
@MIchaelFU0403 MIchaelFU0403 changed the title feat: add trainer configuration [WIP]feat: add trainer configuration Apr 1, 2023
trainer/config/constants.go Outdated Show resolved Hide resolved
trainer/config/testdata/trainer.yaml Outdated Show resolved Hide resolved
Signed-off-by: MIchaelFU0403 <1078537664@qq.com>
Signed-off-by: MIchaelFU0403 <1078537664@qq.com>
Signed-off-by: MIchaelFU0403 <1078537664@qq.com>
Signed-off-by: MIchaelFU0403 <1078537664@qq.com>
Signed-off-by: MIchaelFU0403 <1078537664@qq.com>
@MIchaelFU0403 MIchaelFU0403 changed the title [WIP]feat: add trainer configuration feat: add trainer configuration Apr 3, 2023
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit d955b1b into dragonflyoss:main Apr 3, 2023
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
Signed-off-by: MIchaelFU0403 <1078537664@qq.com>
Signed-off-by: 李龙峰 <lilongfeng@inspur.com>
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Signed-off-by: MIchaelFU0403 <1078537664@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants