Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: when the cache is missing, change the error log to a warning log #2235

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

gaius-qi
Copy link
Member

Description

  • When the cache is missing, change the error log to a warning log.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added enhancement New feature or request manager labels Mar 31, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone Mar 31, 2023
@gaius-qi gaius-qi self-assigned this Mar 31, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner March 31, 2023 11:49
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #2235 (d981fd0) into main (cbf0b38) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2235      +/-   ##
==========================================
- Coverage   49.78%   49.69%   -0.09%     
==========================================
  Files         145      145              
  Lines       19329    19329              
==========================================
- Hits         9622     9606      -16     
- Misses       9114     9129      +15     
- Partials      593      594       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.69% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager/rpcserver/manager_server_v1.go 0.00% <0.00%> (ø)
manager/rpcserver/manager_server_v2.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 0a83607 into main Mar 31, 2023
@gaius-qi gaius-qi deleted the feature/cache-miss branch March 31, 2023 12:17
MIchaelFU0403 pushed a commit to MIchaelFU0403/Dragonfly2 that referenced this pull request Mar 31, 2023
dragonflyoss#2235)

Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: MIchaelFU0403 <1078537664@qq.com>
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
dragonflyoss#2235)

Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: 李龙峰 <lilongfeng@inspur.com>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants