Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CreatedAt function #2244

Merged
merged 3 commits into from
Apr 6, 2023
Merged

feat: add CreatedAt function #2244

merged 3 commits into from
Apr 6, 2023

Conversation

fcgxz2003
Copy link
Member

@fcgxz2003 fcgxz2003 commented Apr 5, 2023

CreatedAt is the function to get creation time of probes.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: XZ <834756128@qq.com>
@fcgxz2003 fcgxz2003 added this to the v2.1.0 milestone Apr 5, 2023
@fcgxz2003 fcgxz2003 self-assigned this Apr 5, 2023
@fcgxz2003 fcgxz2003 requested a review from a team as a code owner April 5, 2023 09:03
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: XZ <834756128@qq.com>
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #2244 (1f5b832) into main (d13bc0e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2244   +/-   ##
=======================================
  Coverage   49.64%   49.64%           
=======================================
  Files         146      146           
  Lines       19505    19507    +2     
=======================================
+ Hits         9683     9684    +1     
- Misses       9226     9227    +1     
  Partials      596      596           
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/networktopology/probes.go 88.00% <100.00%> (+0.32%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit c6d60ca into dragonflyoss:main Apr 6, 2023
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: 李龙峰 <lilongfeng@inspur.com>
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Signed-off-by: XZ <834756128@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants