Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ip and hostname params in FindSchedulerClusters #2249

Merged
merged 1 commit into from
Apr 6, 2023
Merged

fix: ip and hostname params in FindSchedulerClusters #2249

merged 1 commit into from
Apr 6, 2023

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Apr 6, 2023

Description

  • Fix ip and hostname params in FindSchedulerClusters.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.1.0 milestone Apr 6, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner April 6, 2023 10:07
@gaius-qi gaius-qi self-assigned this Apr 6, 2023
garenwen
garenwen previously approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@garenwen garenwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi
fix: ip and hostname params in FindSchedulerClusters
eb847bd 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi merged commit 719fd08 into main Apr 6, 2023
@gaius-qi gaius-qi deleted the feature/searcher branch April 6, 2023 10:12
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
@gaius-qi
fix: ip and hostname params in FindSchedulerClusters (dragonflyoss#2249)
fb8d043 
Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: 李龙峰 <lilongfeng@inspur.com>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
fix: ip and hostname params in FindSchedulerClusters (#2249)
65bf673 
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garenwen garenwen garenwen left review comments

@jim3ma jim3ma Awaiting requested review from jim3ma jim3ma is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@eryugey eryugey Awaiting requested review from eryugey eryugey is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@bigerous bigerous Awaiting requested review from bigerous bigerous is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
bug manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaius-qi @garenwen