Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify the traversal condition for Items #2250

Merged
merged 7 commits into from
Apr 10, 2023
Merged

fix: modify the traversal condition for Items #2250

merged 7 commits into from
Apr 10, 2023

Conversation

fcgxz2003
Copy link
Member

@fcgxz2003 fcgxz2003 commented Apr 7, 2023 •
edited
Loading

Modify the traversal condition for Items.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@fcgxz2003
fix: modify the traversal condition for Items
b80ba72 
Signed-off-by: XZ <834756128@qq.com>
@fcgxz2003 fcgxz2003 added this to the v2.1.0 milestone Apr 7, 2023
@fcgxz2003 fcgxz2003 self-assigned this Apr 7, 2023
@fcgxz2003 fcgxz2003 requested a review from a team as a code owner April 7, 2023 04:17
@fcgxz2003
fix: modify the traversal condition for Items
0571404 
Signed-off-by: XZ <834756128@qq.com>
@codecov
Copy link

codecov bot commented Apr 7, 2023 •
edited
Loading

Codecov Report

Merging #2250 (8bf83e9) into main (719fd08) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2250      +/-   ##
==========================================
- Coverage   49.66%   49.61%   -0.06%     
==========================================
  Files         146      146              
  Lines       19507    19513       +6     
==========================================
- Hits         9688     9681       -7     
- Misses       9224     9234      +10     
- Partials      595      598       +3
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.61% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/networktopology/probes.go 88.46% <100.00%> (+0.46%) ⬆️

... and 6 files with indirect coverage changes

@fcgxz2003
fix: modify the traversal condition for Items
fc1d654 
Signed-off-by: XZ <834756128@qq.com>
@fcgxz2003 fcgxz2003 closed this Apr 7, 2023
@fcgxz2003 fcgxz2003 deleted the probes branch April 7, 2023 08:09
@fcgxz2003 fcgxz2003 restored the probes branch April 7, 2023 08:17
@fcgxz2003 fcgxz2003 reopened this Apr 7, 2023
@gaius-qi gaius-qi changed the title fix: modify the traversal condition for Items [WIP]fix: modify the traversal condition for Items Apr 10, 2023
@gaius-qi gaius-qi changed the title [WIP]fix: modify the traversal condition for Items fix: modify the traversal condition for Items Apr 10, 2023
fcgxz2003 and others added 4 commits April 10, 2023 11:47
@fcgxz2003
fix: modify the time accuracy of the probes unit tests
54bafbb 
Signed-off-by: XZ <834756128@qq.com>
@fcgxz2003
fix:modify the time accuracy of the probes unit tests
8aa97c7 
Signed-off-by: XZ <834756128@qq.com>
@fcgxz2003
fix: change temporary variable
68ef4d7 
Signed-off-by: XZ <834756128@qq.com>
@gaius-qi
feat: optimize averageRTT
8bf83e9 
Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi
gaius-qi approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit c8b0e89 into dragonflyoss:main Apr 10, 2023
@fcgxz2003 fcgxz2003 deleted the probes branch April 12, 2023 11:06
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
@fcgxz2003 @gaius-qi
fix: modify the traversal condition for Items (dragonflyoss#2250)
c3e124e 
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Co-authored-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: 李龙峰 <lilongfeng@inspur.com>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@fcgxz2003 @gaius-qi
fix: modify the traversal condition for Items (#2250)
c5549c8 
Signed-off-by: XZ <834756128@qq.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
Co-authored-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaius-qi gaius-qi gaius-qi approved these changes

@bergwolf bergwolf Awaiting requested review from bergwolf bergwolf is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@garenwen garenwen Awaiting requested review from garenwen garenwen is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@cndoit18 cndoit18 Awaiting requested review from cndoit18 cndoit18 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@fcgxz2003 fcgxz2003

Labels
scheduler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcgxz2003 @gaius-qi