Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid hot reload when dynconfig refresh data #2866

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Nov 8, 2023

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Nov 8, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Nov 8, 2023
@gaius-qi gaius-qi self-assigned this Nov 8, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner November 8, 2023 10:40
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2866 (fd6ba09) into main (2339e9b) will decrease coverage by 0.01%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2866      +/-   ##
==========================================
- Coverage   51.64%   51.63%   -0.01%     
==========================================
  Files         161      161              
  Lines       21809    21815       +6     
==========================================
+ Hits        11263    11264       +1     
- Misses       9884     9889       +5     
  Partials      662      662              
Flag Coverage Δ
unittests 51.63% <14.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/dynconfig/dynconfig.go 66.66% <14.28%> (-4.77%) ⬇️

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 334eb2e into main Nov 8, 2023
21 checks passed
@gaius-qi gaius-qi deleted the feature/hot-reload branch November 8, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants