Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport : dfdaemon to gracefully shutdown #2934

Merged
merged 1 commit into from
Dec 11, 2023
Merged

backport : dfdaemon to gracefully shutdown #2934

merged 1 commit into from
Dec 11, 2023

Conversation

akashhr
Copy link
Contributor

@akashhr akashhr commented Dec 11, 2023

Description

backporting dfdaemon to gracefully shutdown feature to v2.0.9 release.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: akashhr <akashhr2023@gmail.com>
@akashhr akashhr requested a review from a team as a code owner December 11, 2023 06:29
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #2934 (2fe16dc) into release-2.0.9 (b2c11fb) will decrease coverage by 0.04%.
The diff coverage is 9.09%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.0.9    #2934      +/-   ##
=================================================
- Coverage          49.59%   49.55%   -0.04%     
=================================================
  Files                146      146              
  Lines              19520    19530      +10     
=================================================
- Hits                9680     9678       -2     
- Misses              9244     9254      +10     
- Partials             596      598       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.55% <9.09%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/daemon/proxy/proxy.go 13.85% <33.33%> (+0.12%) ⬆️
client/daemon/proxy/proxy_sni.go 0.00% <0.00%> (ø)
client/daemon/proxy/proxy_manager.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit d96e2ad into dragonflyoss:release-2.0.9 Dec 11, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants