Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize parameters in seed peer DownloadTask #2947

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added enhancement New feature or request scheduler labels Dec 18, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Dec 18, 2023
@gaius-qi gaius-qi self-assigned this Dec 18, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner December 18, 2023 13:51
yxxhero
yxxhero previously approved these changes Dec 18, 2023
hyy0322
hyy0322 previously approved these changes Dec 19, 2023
@gaius-qi gaius-qi dismissed stale reviews from hyy0322 and yxxhero via 256a91f December 19, 2023 02:37
@gaius-qi gaius-qi force-pushed the feature/download-task-with-seed-peer branch 2 times, most recently from 256a91f to 3432f50 Compare December 19, 2023 02:44
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi force-pushed the feature/download-task-with-seed-peer branch from 3432f50 to 9781118 Compare December 19, 2023 03:29
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #2947 (9781118) into main (1643750) will decrease coverage by 0.04%.
Report is 8 commits behind head on main.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2947      +/-   ##
==========================================
- Coverage   51.09%   51.06%   -0.04%     
==========================================
  Files         161      161              
  Lines       21836    21836              
==========================================
- Hits        11158    11151       -7     
- Misses      10020    10025       +5     
- Partials      658      660       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.06% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/service/service_v2.go 84.89% <100.00%> (ø)
scheduler/resource/seed_peer.go 19.70% <0.00%> (ø)
scheduler/resource/seed_peer_mock.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 003376c into main Dec 19, 2023
21 checks passed
@gaius-qi gaius-qi deleted the feature/download-task-with-seed-peer branch December 19, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants