Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support logging the range and header when registering a task #2967

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Dec 22, 2023
@gaius-qi gaius-qi self-assigned this Dec 22, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner December 22, 2023 03:29
@gaius-qi gaius-qi added this to the v2.2.0 milestone Dec 22, 2023
@gaius-qi gaius-qi changed the title feat: add range and header to register log in announce peer feat: add range and header for dis Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7b2a807) 51.07% compared to head (0d22a23) 51.05%.

❗ Current head 0d22a23 differs from pull request most recent head cc47287. Consider uploading reports for the commit cc47287 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2967      +/-   ##
==========================================
- Coverage   51.07%   51.05%   -0.03%     
==========================================
  Files         161      161              
  Lines       21888    21890       +2     
==========================================
- Hits        11180    11176       -4     
- Misses      10048    10052       +4     
- Partials      660      662       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
unittests 51.05% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/service/service_v2.go 84.77% <0.00%> (-0.16%) ⬇️

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi changed the title feat: add range and header for dis feat: support logging the range and header when registering a task Dec 22, 2023
@gaius-qi gaius-qi merged commit 5894095 into main Dec 22, 2023
10 of 18 checks passed
@gaius-qi gaius-qi deleted the feature/register-log branch December 22, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants