Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove register seed peer in announce peer #2971

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added enhancement New feature or request scheduler labels Dec 25, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Dec 25, 2023
@gaius-qi gaius-qi self-assigned this Dec 25, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner December 25, 2023 10:33
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6b93ef8) 51.06% compared to head (cffd887) 51.03%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2971      +/-   ##
==========================================
- Coverage   51.06%   51.03%   -0.04%     
==========================================
  Files         161      161              
  Lines       21893    21865      -28     
==========================================
- Hits        11180    11159      -21     
+ Misses      10051    10042       -9     
- Partials      662      664       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.03% <42.85%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/service/service_v2.go 84.79% <42.85%> (-0.03%) ⬇️

... and 1 file with indirect coverage changes

@gaius-qi gaius-qi merged commit acdbc4b into main Dec 25, 2023
21 checks passed
@gaius-qi gaius-qi deleted the feature/remove-register-seed-peer branch December 25, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants