Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peer events state failed when register task #2979

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Dec 26, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Dec 26, 2023
@gaius-qi gaius-qi self-assigned this Dec 26, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner December 26, 2023 08:52
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (ab896da) 51.02% compared to head (d5c3740) 51.09%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2979      +/-   ##
==========================================
+ Coverage   51.02%   51.09%   +0.06%     
==========================================
  Files         161      161              
  Lines       21867    21894      +27     
==========================================
+ Hits        11157    11186      +29     
  Misses      10046    10046              
+ Partials      664      662       -2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.09% <82.60%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/scheduling/scheduling.go 84.64% <100.00%> (+0.99%) ⬆️
scheduler/service/service_v1.go 80.08% <100.00%> (ø)
scheduler/service/service_v2.go 84.85% <67.56%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@gaius-qi gaius-qi merged commit 5989a4d into main Dec 26, 2023
21 checks passed
@gaius-qi gaius-qi deleted the feature/register branch December 26, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants