Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add difference function for slices #2984

Merged
merged 1 commit into from
Dec 29, 2023
Merged

feat: add difference function for slices #2984

merged 1 commit into from
Dec 29, 2023

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Dec 29, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Dec 29, 2023
@gaius-qi gaius-qi self-assigned this Dec 29, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner December 29, 2023 08:07
Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (b9c25f8) 51.00% compared to head (21ec206) 50.94%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2984      +/-   ##
==========================================
- Coverage   51.00%   50.94%   -0.06%     
==========================================
  Files         162      162              
  Lines       22340    22350      +10     
==========================================
- Hits        11395    11387       -8     
- Misses      10284    10304      +20     
+ Partials      661      659       -2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 50.94% <5.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/networktopology/network_topology.go 100.00% <100.00%> (ø)
pkg/slices/slices.go 57.69% <0.00%> (-42.31%) ⬇️

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 4846f6a into main Dec 29, 2023
21 checks passed
@gaius-qi gaius-qi deleted the feature/difference branch December 29, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant