Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker compose document #2997

Merged

Conversation

TommyLike
Copy link
Contributor

Description

Update the docker compose document for local development.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@TommyLike TommyLike requested a review from a team as a code owner January 4, 2024 15:34
@TommyLike TommyLike force-pushed the bug/optimize-docker-compose-readme branch from dd7bb47 to f881cd5 Compare January 4, 2024 15:36
@gaius-qi
Copy link
Member

gaius-qi commented Jan 5, 2024

@TommyLike Please fix the lint, thanks.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbe835e) 51.45% compared to head (f881cd5) 51.43%.

❗ Current head f881cd5 differs from pull request most recent head 5cd6738. Consider uploading reports for the commit 5cd6738 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2997      +/-   ##
==========================================
- Coverage   51.45%   51.43%   -0.02%     
==========================================
  Files         162      162              
  Lines       22171    22171              
==========================================
- Hits        11407    11404       -3     
- Misses      10106    10107       +1     
- Partials      658      660       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.43% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Signed-off-by: TommyLike <tommylikehu@gmail.com>
@TommyLike TommyLike force-pushed the bug/optimize-docker-compose-readme branch from f881cd5 to 5cd6738 Compare January 5, 2024 02:47
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 1e39879 into dragonflyoss:main Jan 5, 2024
10 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants