Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove maxScheduleCount and optimize register in v2 #3001

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jan 8, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added enhancement New feature or request scheduler labels Jan 8, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Jan 8, 2024
@gaius-qi gaius-qi self-assigned this Jan 8, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner January 8, 2024 08:04
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (f1584cf) 51.45% compared to head (99d58ad) 51.44%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3001      +/-   ##
==========================================
- Coverage   51.45%   51.44%   -0.02%     
==========================================
  Files         162      162              
  Lines       22171    22152      -19     
==========================================
- Hits        11407    11395      -12     
+ Misses      10106    10101       -5     
+ Partials      658      656       -2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.44% <57.14%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/config/config.go 90.42% <ø> (+0.91%) ⬆️
scheduler/resource/peer.go 71.95% <ø> (-0.12%) ⬇️
scheduler/scheduling/scheduling.go 84.40% <100.00%> (-0.25%) ⬇️
scheduler/service/service_v2.go 85.29% <40.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

@gaius-qi gaius-qi merged commit 70dd9b1 into main Jan 8, 2024
21 checks passed
@gaius-qi gaius-qi deleted the feature/register branch January 8, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant