Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update scheduler and seed peer by ip and port #3012

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request scheduler labels Jan 10, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Jan 10, 2024
@gaius-qi gaius-qi self-assigned this Jan 10, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner January 10, 2024 03:18
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (93df8f0) 51.41% compared to head (1adff1a) 51.40%.

❗ Current head 1adff1a differs from pull request most recent head 36b8573. Consider uploading reports for the commit 36b8573 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3012      +/-   ##
==========================================
- Coverage   51.41%   51.40%   -0.02%     
==========================================
  Files         162      162              
  Lines       22152    22156       +4     
==========================================
- Hits        11390    11389       -1     
- Misses      10105    10110       +5     
  Partials      657      657              
Flag Coverage Δ
Object-compatibility-e2etests ∅ <ø> (∅)
e2etests ∅ <ø> (∅)
unittests 51.40% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
manager/rpcserver/manager_server_v2.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

hyy0322
hyy0322 previously approved these changes Jan 10, 2024
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi force-pushed the feature/update-scheduler-and-seed-peer branch from 23d6e31 to 36b8573 Compare January 10, 2024 04:36
@gaius-qi gaius-qi merged commit ea28581 into main Jan 10, 2024
18 checks passed
@gaius-qi gaius-qi deleted the feature/update-scheduler-and-seed-peer branch January 10, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants