Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize dfget log #3034

Merged
merged 1 commit into from
Jan 19, 2024
Merged

chore: optimize dfget log #3034

merged 1 commit into from
Jan 19, 2024

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Jan 18, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner January 18, 2024 09:17
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31f0155) 51.34% compared to head (79af3f4) 51.34%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3034   +/-   ##
=======================================
  Coverage   51.34%   51.34%           
=======================================
  Files         162      162           
  Lines       22141    22141           
=======================================
  Hits        11368    11368           
  Misses      10112    10112           
  Partials      661      661           
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 2f04697 into main Jan 19, 2024
21 checks passed
@gaius-qi gaius-qi deleted the chore/optimize-dfget-log branch January 19, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants