Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add leave host to dfdaemon #3070

Merged
merged 1 commit into from
Feb 8, 2024
Merged

feat: add leave host to dfdaemon #3070

merged 1 commit into from
Feb 8, 2024

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Feb 8, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 8, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Feb 8, 2024
@gaius-qi gaius-qi self-assigned this Feb 8, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner February 8, 2024 04:59
Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (3a05eb6) 51.93% compared to head (f67a584) 51.89%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3070      +/-   ##
==========================================
- Coverage   51.93%   51.89%   -0.05%     
==========================================
  Files         163      163              
  Lines       18558    18565       +7     
==========================================
- Hits         9639     9634       -5     
- Misses       8259     8268       +9     
- Partials      660      663       +3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.89% <7.14%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/daemon/rpcserver/rpcserver.go 48.93% <20.00%> (-0.23%) ⬇️
pkg/cache/cache_mock.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@gaius-qi
Copy link
Member Author

gaius-qi commented Feb 8, 2024

@yxxhero

@gaius-qi gaius-qi merged commit a7498d7 into main Feb 8, 2024
21 checks passed
@gaius-qi gaius-qi deleted the feature/leave-host branch February 8, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant