Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ip to keepalive's params #3094

Merged
merged 1 commit into from
Feb 28, 2024
Merged

feat: add ip to keepalive's params #3094

merged 1 commit into from
Feb 28, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request manager labels Feb 28, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Feb 28, 2024
@gaius-qi gaius-qi self-assigned this Feb 28, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner February 28, 2024 12:53
Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 51.94%. Comparing base (c76bc5c) to head (544c8f8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3094      +/-   ##
==========================================
+ Coverage   51.92%   51.94%   +0.01%     
==========================================
  Files         163      163              
  Lines       18578    18600      +22     
==========================================
+ Hits         9647     9662      +15     
- Misses       8268     8277       +9     
+ Partials      663      661       -2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.94% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
manager/rpcserver/manager_server_v2.go 0.00% <0.00%> (ø)
manager/rpcserver/manager_server_v1.go 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 7dcfa68 into main Feb 28, 2024
21 checks passed
@gaius-qi gaius-qi deleted the feature/keepalive branch February 28, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants