Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scheduler storage buffer size limit #3142

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

fcgxz2003
Copy link
Member

@fcgxz2003 fcgxz2003 commented Mar 21, 2024

Fix buffer size limit:
The parameter bufferSize in scheduler storage can not be set to 0.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: XZ <834756128@qq.com>
@fcgxz2003 fcgxz2003 self-assigned this Mar 21, 2024
@fcgxz2003 fcgxz2003 requested a review from a team as a code owner March 21, 2024 13:38
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.92%. Comparing base (ba4c327) to head (4ec5539).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3142   +/-   ##
=======================================
  Coverage   51.92%   51.92%           
=======================================
  Files         163      163           
  Lines       18615    18615           
=======================================
  Hits         9666     9666           
  Misses       8286     8286           
  Partials      663      663           
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/config/config.go 90.43% <100.00%> (ø)

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 8b05b83 into dragonflyoss:main Mar 22, 2024
23 checks passed
@fcgxz2003 fcgxz2003 deleted the fix branch June 24, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants