Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize log #3151

Merged
merged 1 commit into from
Mar 28, 2024
Merged

chore: optimize log #3151

merged 1 commit into from
Mar 28, 2024

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Mar 26, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner March 26, 2024 10:39
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 51.88%. Comparing base (49ac8d5) to head (ec1bdef).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3151      +/-   ##
==========================================
- Coverage   51.89%   51.88%   -0.01%     
==========================================
  Files         163      163              
  Lines       18621    18621              
==========================================
- Hits         9663     9662       -1     
- Misses       8293     8294       +1     
  Partials      665      665              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.88% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/resource/seed_peer_client.go 77.92% <100.00%> (ø)
client/daemon/peer/peertask_conductor.go 53.38% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit d4ac1cc into main Mar 28, 2024
23 checks passed
@gaius-qi gaius-qi deleted the chore/optimize-log branch March 28, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants