Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce the scheduler return content of the parent #3349

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Jun 27, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Jun 27, 2024
@gaius-qi gaius-qi self-assigned this Jun 27, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner June 27, 2024 13:45
Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.50%. Comparing base (4aa12f8) to head (279d249).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3349      +/-   ##
==========================================
- Coverage   52.58%   52.50%   -0.09%     
==========================================
  Files         192      192              
  Lines       20462    20428      -34     
==========================================
- Hits        10760    10725      -35     
  Misses       8899     8899              
- Partials      803      804       +1     
Flag Coverage Δ
unittests 52.50% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/scheduling/scheduling.go 84.21% <ø> (+0.15%) ⬆️

... and 3 files with indirect coverage changes

@gaius-qi gaius-qi merged commit aacf7e4 into main Jun 27, 2024
28 checks passed
@gaius-qi gaius-qi deleted the feature/parent branch June 27, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant