Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize hijack ca format #3418

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Aug 6, 2024

Description

Support inline PEM format for hijacking HTTPS CA

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner August 6, 2024 03:55
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.70%. Comparing base (89e06a8) to head (1648f9e).

Files Patch % Lines
client/daemon/proxy/proxy_manager.go 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3418      +/-   ##
==========================================
- Coverage   52.73%   52.70%   -0.03%     
==========================================
  Files         193      193              
  Lines       20488    20488              
==========================================
- Hits        10804    10798       -6     
- Misses       8878     8882       +4     
- Partials      806      808       +2     
Flag Coverage Δ
unittests 52.70% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/config/peerhost.go 47.46% <ø> (ø)
client/daemon/proxy/proxy_manager.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xujihui1985 xujihui1985 merged commit 9698903 into main Aug 6, 2024
29 checks passed
@xujihui1985 xujihui1985 deleted the chore/optimize-hijack-ca-format branch August 6, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants