Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: seed max concurrent #3482

Merged
merged 2 commits into from
Sep 23, 2024
Merged

feat: seed max concurrent #3482

merged 2 commits into from
Sep 23, 2024

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Sep 4, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma jim3ma requested a review from a team as a code owner September 4, 2024 03:50
@jim3ma jim3ma changed the title feat: seed mac concurrent feat: seed max concurrent Sep 4, 2024
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.01%. Comparing base (75d6242) to head (f331439).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
client/daemon/rpcserver/seeder.go 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3482      +/-   ##
==========================================
- Coverage   52.02%   52.01%   -0.02%     
==========================================
  Files         188      188              
  Lines       20253    20261       +8     
==========================================
+ Hits        10537    10538       +1     
- Misses       8913     8918       +5     
- Partials      803      805       +2     
Flag Coverage Δ
unittests 52.01% <88.88%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/config/peerhost.go 47.46% <ø> (ø)
client/daemon/rpcserver/rpcserver.go 49.24% <100.00%> (+0.15%) ⬆️
client/daemon/rpcserver/seeder.go 55.65% <83.33%> (+0.77%) ⬆️

... and 2 files with indirect coverage changes

Signed-off-by: Jim Ma <majinjing3@gmail.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 3e73231 into main Sep 23, 2024
29 checks passed
@gaius-qi gaius-qi deleted the feat/seed-max-concurrent branch September 23, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants