Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add downloadRate and uploadRate for host #3548

Merged
merged 3 commits into from
Sep 30, 2024
Merged

feat: add downloadRate and uploadRate for host #3548

merged 3 commits into from
Sep 30, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
…e/rate

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Sep 30, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Sep 30, 2024
@gaius-qi gaius-qi self-assigned this Sep 30, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner September 30, 2024 10:14
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi
Copy link
Member Author

This pull request includes several changes to enhance the handling of network rates and limits for hosts in the scheduler module. The key updates involve adding new fields to the Network struct, updating methods to handle these fields, and ensuring corresponding test cases are updated.

Enhancements to Network Rate Handling:

Updates to Methods:

Test Case Updates:

Dependency Update:

  • go.mod: Updated the dependency d7y.io/api/v2 from v2.0.164 to v2.0.166.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.75%. Comparing base (8d956eb) to head (5281d44).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3548      +/-   ##
==========================================
+ Coverage   49.71%   49.75%   +0.04%     
==========================================
  Files         186      186              
  Lines       19511    19527      +16     
==========================================
+ Hits         9699     9715      +16     
- Misses       9017     9018       +1     
+ Partials      795      794       -1     
Flag Coverage Δ
unittests 49.75% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/resource/standard/host.go 90.32% <ø> (ø)
scheduler/scheduling/scheduling.go 84.49% <100.00%> (+0.16%) ⬆️
scheduler/service/service_v2.go 78.87% <100.00%> (+0.31%) ⬆️

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 4d2e929 into main Sep 30, 2024
25 of 29 checks passed
@gaius-qi gaius-qi deleted the feature/rate branch September 30, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant