Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JFR] A wrong parameter is passed to the constructor of LeakKlassWriter #296

Closed
D-D-H opened this issue Feb 9, 2022 · 0 comments
Closed

[JFR] A wrong parameter is passed to the constructor of LeakKlassWriter #296

D-D-H opened this issue Feb 9, 2022 · 0 comments
Assignees
@D-D-H

Comments

@D-D-H
Copy link
Collaborator

D-D-H commented Feb 9, 2022

The constructor of LeakKlassWriter:

typedef JfrTypeWriterHost<LeakKlassWriterImpl, TYPE_CLASS> LeakKlassWriter;
JfrTypeWriterHost(JfrCheckpointWriter* writer,                    
                                bool class_unload = false,
                                bool skip_header = false)

Wrong call site at jfrTypeSet.cpp:

303     LeakKlassWriter lkw(_leakp_writer, _artifacts, _class_unload);
304     CompositeKlassWriter ckw(&lkw, &kw);
305     CompositeKlassWriterRegistration ckwr(&ckw, &reg);
306     CompositeKlassCallback callback(&ckwr);
307     _subsystem_callback = &callback;

Should not pass _artifacts to the constructor at L303.
@D-D-H D-D-H self-assigned this Feb 9, 2022
@D-D-H D-D-H changed the title [JFR] pass a wrong parameter to LeakKlassWriter constructor [JFR] A wrong parameter is passed to LeakKlassWriter constructor Feb 9, 2022
@D-D-H D-D-H changed the title [JFR] A wrong parameter is passed to LeakKlassWriter constructor [JFR] A wrong parameter is passed to the constructor of LeakKlassWriter Feb 9, 2022
@D-D-H D-D-H mentioned this issue Feb 9, 2022
Merged
D-D-H added a commit to dragonwell-project/dragonwell8_hotspot that referenced this issue Feb 9, 2022
@D-D-H
[JFR] A wrong parameter is passed to the constructor of LeakKlassWriter
5e757e6 
Summary: remove the wrong parameter

Test Plan: jtreg jdk/jfr

Reviewed-by: kelthuzadx, joeyleeeeeee97, yuleil

Issue: dragonwell-project/dragonwell8#296
@D-D-H D-D-H closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@D-D-H D-D-H

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@D-D-H