Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Build failure on windows #601

Closed
jia-wei-tang opened this issue Nov 1, 2023 · 1 comment
Closed

[Bug] Build failure on windows #601

jia-wei-tang opened this issue Nov 1, 2023 · 1 comment

Comments

@jia-wei-tang
Copy link
Collaborator

jia-wei-tang commented Nov 1, 2023 •
edited
Loading

Description
Cannot build on windows.
Output as follows:
C:\workspace\openjdk-build\workspace\build\src\hotspot\src\share\vm\runtime\quickStart.cpp(565) : error C2220: warning treated as error - no 'object' file generated
C:\workspace\openjdk-build\workspace\build\src\hotspot\src\share\vm\runtime\quickStart.cpp(565) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data
C:\workspace\openjdk-build\workspace\build\src\hotspot\src\share\vm\runtime\quickStart.cpp(568) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data
C:\workspace\openjdk-build\workspace\build\src\hotspot\src\share\vm\runtime\quickStart.cpp(589) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data
C:\workspace\openjdk-build\workspace\build\src\hotspot\src\share\vm\runtime\quickStart.cpp(1133) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data
C:\workspace\openjdk-build\workspace\build\src\hotspot\src\share\vm\runtime\quickStart.cpp(1135) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data

Steps to Reproduce
make images

Expected behavior
Build success.

JDK version
OpenJDK 64-Bit Server VM (Alibaba Dragonwell Extended Edition 8.16.17)

Execution environment
windows
@jia-wei-tang
Copy link
Collaborator Author

15:54:24 C:\workspace\openjdk-build\workspace\build\src\hotspot\src\share\vm\runtime\quickStart.cpp(565) : error C2220: warning treated as error - no 'object' file generated
15:54:24 C:\workspace\openjdk-build\workspace\build\src\hotspot\src\share\vm\runtime\quickStart.cpp(565) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data
15:54:24 C:\workspace\openjdk-build\workspace\build\src\hotspot\src\share\vm\runtime\quickStart.cpp(568) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data
15:54:24 C:\workspace\openjdk-build\workspace\build\src\hotspot\src\share\vm\runtime\quickStart.cpp(589) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data
15:54:24 C:\workspace\openjdk-build\workspace\build\src\hotspot\src\share\vm\runtime\quickStart.cpp(1133) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data
15:54:24 C:\workspace\openjdk-build\workspace\build\src\hotspot\src\share\vm\runtime\quickStart.cpp(1135) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data

@jia-wei-tang jia-wei-tang reopened this Nov 1, 2023
jia-wei-tang added a commit to jia-wei-tang/dragonwell8 that referenced this issue Nov 1, 2023
@jia-wei-tang
[EagerAppCDS] fix build failure on windows
e55322f 
Summary: As title. We need to convert size_t to int obviously on windows.

Test Plan: windows build

Reviewed-by: lingjun-cg, yuleil

Issue: dragonwell-project#601
CR:
@jia-wei-tang jia-wei-tang mentioned this issue Nov 1, 2023
Merged
jia-wei-tang added a commit that referenced this issue Nov 6, 2023
@jia-wei-tang
[EagerAppCDS] fix build failure on windows
b09c6e0 
Summary: As title. We need to convert size_t to int obviously on windows.

Test Plan: windows build

Reviewed-by: lingjun-cg, yuleil

Issue: #601
CR:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jia-wei-tang