-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Add Mozilla cacerts #28
Conversation
1, pls sign CLA, anyway |
2b991df
to
d6570a2
Compare
Accept. Already move cacerts file to common/security. I also add another cacerts.list.txt to make cacerts human readable. |
Please create an issue, link it to this patch, and update the 'Issue: ' field from commit template. |
That does sound sufficient to me, is there any existing JTreg/JCK tests related to this change? |
how was |
Make some improvement according to luchsh comments.
|
pwd is not robust, how about readlink -f ./ |
Summary: Add Mozilla cacerts Test Plan: Covered by Mozilla Network Security Service Reviewed-by: D-D-H, luchsh Issue: dragonwell-project#29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
@@ -62,12 +60,17 @@ else | |||
BUILD_INDEX=b$BUILD_NUMBER | |||
fi | |||
|
|||
DISTRO_VERSION=${DRAGONWELL_VERSION}-${BUILD_INDEX} | |||
DISTRO_NAME="Alibaba Dragonwell" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls move this change to another patch。
and you should update common/autoconf/spec.gmk.in instead
DRAGONWELL_JDK_UPDATE_VERSION=202 | ||
DRAGONWELL_JDK_BUILD_NUMBER=b01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not change this, pls create another patch
Summary: Add mozilla cacerts
Test Plan: Covered by Mozilla Network Security Service
Reviewed-by: D-D-H, luchsh
Issue: #29