-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] change default gc from CMS to PS #562
Conversation
Summary: The same as title Test Plan: hotspot/test/gc/TestDefaultGC.sh Reviewed-by: kuaiwei, JoshuaZhuwj Issue: dragonwell-project#561
It's not an aarch64 specific fix, please change the commit message as "change default gc from CMS to PS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
serviceability/sa/jmap-minidump/TestNoMinidumpAtFullGC.java #513 |
测试中挂掉的case是以前的PR引起的 |
@@ -1605,7 +1605,7 @@ void Arguments::select_gc_ergonomically() { | |||
|
|||
void Arguments::select_gc() { | |||
if (!gc_selected()) { | |||
FLAG_SET_ERGO(bool, UseConcMarkSweepGC, true); | |||
select_gc_ergonomically(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
select_gc_ergonomically 这个代表什么含义呀
Summary: The same as title
Test Plan: hotspot/test/gc/TestDefaultGC.sh
Reviewed-by: kuaiwei, JoshuaZhuwj
Issue: #561