Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] change default gc from CMS to PS #562

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

sandlerwang
Copy link
Collaborator

Summary: The same as title

Test Plan: hotspot/test/gc/TestDefaultGC.sh

Reviewed-by: kuaiwei, JoshuaZhuwj

Issue: #561

Summary: The same as title

Test Plan: hotspot/test/gc/TestDefaultGC.sh

Reviewed-by: kuaiwei, JoshuaZhuwj

Issue: dragonwell-project#561
@CLAassistant
Copy link

CLAassistant commented Jul 14, 2023

CLA assistant check
All committers have signed the CLA.

@kuaiwei
Copy link
Collaborator

kuaiwei commented Jul 14, 2023

It's not an aarch64 specific fix, please change the commit message as "change default gc from CMS to PS"

Copy link
Collaborator

@tanghaoth90 tanghaoth90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandlerwang sandlerwang changed the title [Misc] change default gc in aarch64 from CMS to PS [Misc] change default gc from CMS to PS Jul 18, 2023
@sandlerwang
Copy link
Collaborator Author

serviceability/sa/jmap-minidump/TestNoMinidumpAtFullGC.java #513

@sandlerwang
Copy link
Collaborator Author

serviceability/sa/jmap-minidump/TestNoMinidumpAtFullGC.java #513

测试中挂掉的case是以前的PR引起的

@sandlerwang sandlerwang merged commit dc18872 into dragonwell-project:master Jul 18, 2023
@@ -1605,7 +1605,7 @@ void Arguments::select_gc_ergonomically() {

void Arguments::select_gc() {
if (!gc_selected()) {
FLAG_SET_ERGO(bool, UseConcMarkSweepGC, true);
select_gc_ergonomically();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select_gc_ergonomically 这个代表什么含义呀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants