Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

melonDS DS Migration #956

Merged
5 commits merged into from Jan 25, 2024
Merged

melonDS DS Migration #956

5 commits merged into from Jan 25, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2024

New melonDS RetroArch core: https://github.com/JesseTG/melonds-ds

  • Copied old melonDS saves to new melonDSDS
  • Copied old melonDS remaps to new melonDSDS
  • Added new "Nintendo DS - RetroArch melonDS DS" Steam ROM Manager parser
  • Added "(legacy)" to old melonDS Steam ROM Manager parser
  • Added melonDSDS function to match new configuration files
  • Updated microphone driver to SDL
  • No file deletion, legacy melonDS (saves and remaps) still left in tact

@ghost ghost marked this pull request as draft January 22, 2024 20:00
Copy link
Contributor

@JesseTG JesseTG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your hard work on getting this into EmuDeck. With the sensible defaults that I already provide, I don't think you need to do much (if any) core option overrides.

functions/EmuScripts/emuDeckRetroArch.sh Outdated Show resolved Hide resolved
functions/EmuScripts/emuDeckRetroArch.sh Outdated Show resolved Hide resolved
functions/EmuScripts/emuDeckRetroArch.sh Outdated Show resolved Hide resolved
functions/EmuScripts/emuDeckRetroArch.sh Show resolved Hide resolved
functions/EmuScripts/emuDeckRetroArch.sh Outdated Show resolved Hide resolved
functions/EmuScripts/emuDeckRetroArch.sh Outdated Show resolved Hide resolved
functions/EmuScripts/emuDeckRetroArch.sh Outdated Show resolved Hide resolved
functions/EmuScripts/emuDeckRetroArch.sh Outdated Show resolved Hide resolved
functions/EmuScripts/emuDeckRetroArch.sh Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jan 23, 2024

I appreciate your hard work on getting this into EmuDeck. With the sensible defaults that I already provide, I don't think you need to do much (if any) core option overrides.

Thank you! I'll likely leave most of the defaults. The EmuDeck application offers a way to reset RetroArch configurations to EmuDeck defaults so having these set should help the user anyway.

I could be mistaken about how that works exactly though, may not need the configuration lines after all.

rawdatafeel added 2 commits January 22, 2024 20:16
* Copied old melonDS saves to new melonDSDS
* Copied old melonDS remaps to new melonDSDS
* Added new "Nintendo DS - RetroArch melonDS DS" Steam ROM Manager parser
* Added "(legacy)" to old melonDS Steam ROM Manager parser
* Added melonDSDS function to match new configuration files
* Updated microphone driver to SDL
* No file deletion, legacy melonDS (saves and remaps) still left in tact
@ghost ghost marked this pull request as ready for review January 23, 2024 01:19
Copy link
Collaborator

@Godsbane Godsbane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

If @JesseTG is good with it, then I'd say merge away.

@JesseTG
Copy link
Contributor

JesseTG commented Jan 24, 2024

Looks good to me.

If @JesseTG is good with it, then I'd say merge away.

I am. Ship it. 👍

@ghost ghost merged commit 6835aec into dragoonDorise:dev Jan 25, 2024
1 check passed
@ghost ghost deleted the melondsds branch January 31, 2024 16:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants