Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mark2confluence): Check if mark headers are present at the beginning of the page #18

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

gmarraff
Copy link
Collaborator

The function has_mark_headers was returning True when a mark header was present in the file.

However files with headers in the content, for example:

# How to push to confluence

Create a markdown file with mark headers:
     <!-- Space: FOO ->
     # Page Title

Were also processed, causing the mark binary to fail because it couldn't find headers.

This PR fixes it by checking the presence of mark headers in the first line of the file.

@gmarraff gmarraff requested a review from a team as a code owner January 31, 2024 10:18
@gmarraff gmarraff merged commit 45d0dd1 into main Jan 31, 2024
3 checks passed
@gmarraff gmarraff deleted the fix-check-mark-headers-at-beginning branch January 31, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants