Made some fields to be final

drakeet · Sep 15, 2017 · 35e2679 · 35e2679
1 parent bd09e8a
commit 35e2679
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/library/src/main/java/me/drakeet/floo/Configuration.java b/library/src/main/java/me/drakeet/floo/Configuration.java
@@ -34,7 +34,7 @@
  */
 public class Configuration {
 
-    private @NonNull TargetMap targetMap;
+    private @NonNull final TargetMap targetMap;
     private @NonNull final List<TargetNotFoundHandler> targetNotFoundHandlers;
     private @NonNull final List<Interceptor> requestInterceptors;
     private @NonNull final List<Interceptor> targetInterceptors;
@@ -126,7 +126,6 @@ Target getTarget(@NonNull String url) {
     @RequiresApi(api = Build.VERSION_CODES.ICE_CREAM_SANDWICH)
     void initStackObserverIfNeed(@NonNull Activity activity) {
         if (!stackObserverInitialized) {
-
             activity.getApplication().registerActivityLifecycleCallbacks(
                 new ActivityOnResumeCallback() {
 
@@ -135,6 +134,7 @@ public void onActivityResumed(@NonNull Activity activity) {
                         StackManager.onActivityResumed(activity);
                     }
                 });
+            stackObserverInitialized = true;
         }
     }
 }
diff --git a/library/src/main/java/me/drakeet/floo/Floo.java b/library/src/main/java/me/drakeet/floo/Floo.java
@@ -51,9 +51,9 @@ public final class Floo implements Navigation {
 
     private static final Configuration CONFIGURATION = new Configuration();
 
-    private @NonNull Context context;
-    private @NonNull Bundle bundle;
-    private @NonNull Map<String, String> queryParams;
+    private @NonNull final Context context;
+    private @NonNull final Bundle bundle;
+    private @NonNull final Map<String, String> queries;
     private @NonNull Uri sourceUri;
 
     private @Nullable Uri targetUri;
@@ -64,7 +64,7 @@ private Floo(@NonNull Context context, @NonNull String url) {
         this.context = context;
         this.bundle = new Bundle();
         this.sourceUri = Uri.parse(url);
-        this.queryParams = new HashMap<>();
+        this.queries = new HashMap<>();
     }
 
 
@@ -173,7 +173,7 @@ public Navigation putExtras(@NonNull Bundle bundle) {
      */
     @NonNull @Override @CheckResult
     public Navigation appendQueryParameter(@NonNull String key, @NonNull String value) {
-        queryParams.put(key, value);
+        queries.put(key, value);
         return this;
     }
 
@@ -221,7 +221,7 @@ public void ifIntentNonNullSendTo(@NonNull IntentReceiver receiver) {
      */
     @Nullable @Override @CheckResult
     public Intent getIntent() {
-        sourceUri = appendSourceUri(sourceUri, queryParams);
+        sourceUri = appendSourceUri(sourceUri, queries);
         Chain chain = interceptRequest(sourceUri);
         sourceUri = chain.request();
         if (chain.isProceed()) {