Added: Random Passwords #48

123FLO321 · 2017-06-06T02:13:49Z

added random passwords if no password is specified (for Sequence and Single)
added "pl" flag to specify length of random passwords (defaults: random)

drallieiv

I would rather have user specify their format and split the char pools into named groups with single char alias that could be grouped in a map

A for uppercase letters
b (or a) for lowercase letters
0 for numbers
+ for symbols
x for anything

the same way I give a format for the username i could give :

xxxxxxxx for a 8 char full random password
AbbAbb0000+ for a 100 chars starting with 6 letters, then 4 numbers then a symbol

Also utility class wise the characters set should be able to be customized (no need to go up to the command line for that).

But as far as core could be used as a depency, I should be able to remove the symbols that cannot be typed easily in my language, avoir similar chars such as 0 and O.

Cool idea but not required :

One step further would be to use strings instead of chars, which would let me use phonetic words in order to make a password that can be said or remembered easily. Much like Japanese romanji does.

drallieiv · 2017-06-06T04:38:39Z

KinanCity-core/src/main/java/com/kinancity/core/CliOptions.java

@@ -13,6 +13,7 @@
 	EMAIL("m", "mail", true, "account email address"),
 	SINGLE_USERNAME("u", "username", true, "account username/login"),
 	PASSWORD("p", "password", true, "account password"),
+	PASSWORD_LENGTH("pl", "passwordLength", true, "random account password length"),


Options key should not overlap each other one should not start like the other.
"p" is contained in "pl"

drallieiv · 2017-06-06T04:40:43Z

KinanCity-core/src/main/java/com/kinancity/core/generator/password/RandomPasswordGenerator.java

+
+	private int length;
+
+	public RandomPasswordGenerator(Integer length) {


There is no need to take an Integer as paramter, primitive int would be better to avoid null checks

drallieiv · 2017-06-06T04:43:33Z

KinanCity-core/src/main/java/com/kinancity/core/KinanCityCli.java

@@ -106,22 +109,36 @@ private static Configuration updateConfiguration(Configuration config, Options o

 		// 3 types of generation : unique, csv and sequence


Password generator could also be used with csv input, if the password header is not added in file.

This could be part of another PR.

drallieiv · 2017-06-06T04:44:30Z

KinanCity-core/src/main/java/com/kinancity/core/KinanCityCli.java

 			sequenceGenerator.setUsernamePattern(cmd.getOptionValue(CliOptions.SEQ_ACCOUNTS_FORMAT.shortName));
 			sequenceGenerator.setNbAccounts(Integer.parseInt(cmd.getOptionValue(CliOptions.SEQ_ACCOUNTS_COUNT.shortName)));
 			sequenceGenerator.setStartFrom(Integer.parseInt(cmd.getOptionValue(CliOptions.SEQ_ACCOUNTS_START.shortName, "0")));
+			if (cmd.hasOption(CliOptions.PASSWORD.shortName)) {


Duplicate code should be joined as one.

PasswordGenerator definition could be done before the "3 types of generation" fork

drallieiv · 2017-06-06T04:47:58Z

KinanCity-core/src/main/java/com/kinancity/core/generator/password/RandomPasswordGenerator.java

+	private static final int MIN_LENGTH = 8;
+	private static final int MAX_LENGTH = 50;
+
+	private static Logger LOGGER = LoggerFactory.getLogger(KinanCityCli.class);


On other classes I currently use instance loggers :
private Logger logger = LoggerFactory.getLogger(getClass());

drallieiv · 2017-06-06T04:51:49Z

KinanCity-core/src/main/java/com/kinancity/core/generator/password/RandomPasswordGenerator.java

+			LOGGER.warn("Password length must be a number! Using a random length!");
+			this.length = -1;
+		}
+		else if (length < 0) {


style : else if should be on the same line then the closing bracket of previous if

drallieiv · 2017-06-06T04:56:56Z

...nCity-core/src/test/java/com/kinancity/core/generator/impl/SequenceAccountGeneratorTest.java


 		data = generator.next();
 		assertThat(data).isNotNull();
 		assertThat(data.getUsername()).isEqualTo("pref01235suf");
+		assertThat(data.getPassword().length()).isBetween(8, 50);


Using the same regexp or calling directly isAccountValid would be better.

https://github.com/drallieiv/KinanCity/blob/develop/ptc-api/src/main/java/com/kinancity/api/PtcSession.java

123FLO321 · 2017-06-06T14:06:31Z

How about not adding a now flag but adding these formats to the default password flag.
Maybe: "Pa\xswordxxx" xxx gets replaced and \x stays as x

Chars would only be replaced if the char is inside the char pool.
The char pool is empty be default but can be replaced inside the config file (or remove a # if you just use the preset one.

So by defaults Passwordxxx stays Passwordxxx

Config file default:
#pwPool.A = A,B,C,D,...
#pwPool.a = a,b,c,d,...
#pwPool0 = 0,1,2,3,..
#pwPool.+ = (,),&,%,...
#pwPool.x = all
There you could also add custom ones like this:
pwPool.i = Hello, World, ...

neskk · 2017-06-11T15:06:11Z

@123FLO321 any chance you can finish the alterations requested by drallieiv? Having the ability to set a pattern for password generation is completely optional for me but it's a nice feature.
Not having to type a new random password for every set of accounts I am about to create is a great idea.
I would take this a step further and define the "template"/string substitution engine and let it be used both in Password and Username fields.
The country code should also be able to be specified in a command line argument for flexibility.
Random complaint to @drallieiv: for some reason not checking if nickname is available before requesting a Captcha is non-sense to me. To create ~1800 accounts 2 captcha reported around 2600 captchas submitted. As I pointed out in Discord the other day, 30% waste on captchas is expensive and all because Kinan doesn't want to make a simple HTTP request to check if username is available for each account being created causing captchas to be requested and going to waste. I can't believe that the number of username checks an IP can make if inferior to the number of accounts that can be registered and because of this there's no reason that for every account created a username check is made to make sure we don't waste a captcha. I haven't had time to test stuff, been busy with my exams, maybe today I take a look into the code.
Good work @123FLO321 👍

123FLO321 · 2017-06-11T22:07:46Z

@neskk Yes, I'll continue working on this soon. And I guess also implementing it into the username.

drallieiv · 2017-06-11T22:07:48Z

It would definately be easier to have 2 distinct parameters for fixed password and random password.
current fixed password would become fixed-password, fp and adding random-password, rpfor the new password format.

As for using "pwPool.i" properties file reading can only be done if the key is known

drallieiv · 2017-06-11T22:08:37Z

@neskk I already explained myself on DM, username check is already implemented on the API but was removed from the process. If you want to put it back, create a separate pull request using it, and prove me wrong.

123FLO321 · 2017-06-11T22:11:56Z

@drallieiv I don't see any reason to have 2 separate password parameters since random pw/username would be disabled by default.
So:
-pr (password-random) and/or
-ur (username-random) would enable that feature.

neskk · 2017-06-11T22:38:14Z

@123FLO321 I think @drallieiv was thinking when you want to distinguish "pure random" from "pattern random"
My opinion is this: --random-password would not accept any parameter and just be a pure random password based on a fixed pattern (maybe variable length, rolling pattern, etc). --password would accept a pattern or, here's the tricky part, a fixed password. Problem comes when you want to distinguish fixed password/username from pattern one, i.e. how do you know if '123abc+' is meant to be a fixed password or random like '123abc%', '123abc!', etc.?
Maybe we actually need an extra flag to disable pattern substitution so we could input a "fixed" password with symbols that are placeholders in pattern mode.

123FLO321 · 2017-06-11T22:42:46Z

@neskk "-pw Password+" would not be replaced by default.
only if --random-password is added.
And even then it only gets replaced if "+" is in the set. If you want a "+" you can type "+".

neskk · 2017-06-11T23:05:33Z

@123FLO321 ah ok I think I understood now... what you mean is that these three options exist, right?

-pw format + -random-pass - random password with pattern
-pw literal - fixed password
-random-pass - pure random password

I think it would be cool if username could use the same logic as password to generate random usernames.

123FLO321 · 2017-06-11T23:08:45Z

@neskk No only 2 (+pool) new ones: enable random password and enable random username.

tomballgithub · 2017-07-05T15:33:32Z

Agree with @neskk that random usernames are needed also to avoid Niantic detection from looking for patterns in future. Currently I am creating random usernames/passwords in excel and importing them into KinanCity.

drallieiv · 2021-04-28T16:53:43Z

If anyone wants to work on that, let me know

Added: Random Passwords

897c2a9

drallieiv requested changes Jun 6, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added: Random Passwords #48

Added: Random Passwords #48

123FLO321 commented Jun 6, 2017

drallieiv left a comment

drallieiv Jun 6, 2017

drallieiv Jun 6, 2017

drallieiv Jun 6, 2017

drallieiv Jun 6, 2017

drallieiv Jun 6, 2017

drallieiv Jun 6, 2017

drallieiv Jun 6, 2017

123FLO321 commented Jun 6, 2017 •

edited

Loading

neskk commented Jun 11, 2017

123FLO321 commented Jun 11, 2017

drallieiv commented Jun 11, 2017

drallieiv commented Jun 11, 2017

123FLO321 commented Jun 11, 2017

neskk commented Jun 11, 2017

123FLO321 commented Jun 11, 2017

neskk commented Jun 11, 2017

123FLO321 commented Jun 11, 2017

tomballgithub commented Jul 5, 2017

drallieiv commented Apr 28, 2021


		private int length;

		public RandomPasswordGenerator(Integer length) {

		@@ -106,22 +109,36 @@ private static Configuration updateConfiguration(Configuration config, Options o

		// 3 types of generation : unique, csv and sequence

Added: Random Passwords #48

Are you sure you want to change the base?

Added: Random Passwords #48

Conversation

123FLO321 commented Jun 6, 2017

drallieiv left a comment

Choose a reason for hiding this comment

drallieiv Jun 6, 2017

Choose a reason for hiding this comment

drallieiv Jun 6, 2017

Choose a reason for hiding this comment

drallieiv Jun 6, 2017

Choose a reason for hiding this comment

drallieiv Jun 6, 2017

Choose a reason for hiding this comment

drallieiv Jun 6, 2017

Choose a reason for hiding this comment

drallieiv Jun 6, 2017

Choose a reason for hiding this comment

drallieiv Jun 6, 2017

Choose a reason for hiding this comment

123FLO321 commented Jun 6, 2017 • edited Loading

neskk commented Jun 11, 2017

123FLO321 commented Jun 11, 2017

drallieiv commented Jun 11, 2017

drallieiv commented Jun 11, 2017

123FLO321 commented Jun 11, 2017

neskk commented Jun 11, 2017

123FLO321 commented Jun 11, 2017

neskk commented Jun 11, 2017

123FLO321 commented Jun 11, 2017

tomballgithub commented Jul 5, 2017

drallieiv commented Apr 28, 2021

123FLO321 commented Jun 6, 2017 •

edited

Loading