Skip to content

Commit

Permalink
make constants z0 and z1 private
Browse files Browse the repository at this point in the history
  • Loading branch information
kevincharm committed Feb 16, 2024
1 parent 20d9bb3 commit 8d239d2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions pairing/bn254/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ var xiToPSquaredMinus1Over6 = &gfP{0xca8d800500fa1bf2, 0xf0c5d61468b39769, 0x0e2
var xiTo2PMinus2Over3 = &gfP2{gfP{0x5dddfd154bd8c949, 0x62cb29a5a4445b60, 0x37bc870a0c7dd2b9, 0x24830a9d3171f0fd}, gfP{0x7361d77f843abe92, 0xa5bb2bd3273411fb, 0x9c941f314b3e2399, 0x15df9cddbb9fd3ec}}

// sqrt(-3)
var Z0 = bigFromBase10("4407920970296243842837207485651524041948558517760411303933")
var z0 = bigFromBase10("4407920970296243842837207485651524041948558517760411303933")

// (sqrt(-3) - 1) / 2
var Z1 = bigFromBase10("2203960485148121921418603742825762020974279258880205651966")
var z1 = bigFromBase10("2203960485148121921418603742825762020974279258880205651966")
4 changes: 2 additions & 2 deletions pairing/bn254/point.go
Original file line number Diff line number Diff line change
Expand Up @@ -252,15 +252,15 @@ func mapToPoint(x *big.Int) (*big.Int, *big.Int) {

a0 := mulmodp(x, x)
a0 = addmodp(a0, new(big.Int).SetUint64(4))
a1 := mulmodp(x, Z0)
a1 := mulmodp(x, z0)
a2 := mulmodp(a1, a0)
a2 = a2.ModInverse(a2, p)
a1 = mulmodp(a1, a1)
a1 = mulmodp(a1, a2)

// x1
a1 = mulmodp(x, a1)
x = addmodp(Z1, new(big.Int).Sub(p, a1))
x = addmodp(z1, new(big.Int).Sub(p, a1))
// check curve
a1 = mulmodp(x, x)
a1 = mulmodp(a1, x)
Expand Down

0 comments on commit 8d239d2

Please sign in to comment.