-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for signatures on the G2 curve for BDN #53
Conversation
I would also like to mention that my understanding of the code is still rather superficial. This shows, for example, that I did not manage to generalize the unit tests. Please make sure that the code actually works before merging. Thanks! |
Hey @AnomalRoil let me know what needs to get done to get this merged. |
It needs more tests I guess, which has been on my to-do for like 2 months 😅 |
While working on more tests, I discovered that This is not an issue with bls12381 we are using. |
Pull in Kubuxu@c5d6a11 for additional tests |
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
I just need to add some retro-compat functions to avoid breaking public APIs and I'll release a new minor release with this 👍🏻 |
* Add support for signatures on G2 to bdn * Adapt bdn_test.go to new BDN interface * Make API functions methods of the Scheme type * Generalize G1- and G2-related comments * Fixing bdn tests * Make the BDN test suite generic over suite and scheme * Keeping public APIs from v1 --------- Co-authored-by: Yolan Romailler <anomalroil@users.noreply.github.com> Co-authored-by: Jakub Sztandera <kubuxu@protocol.ai>
Feel free to further edit the code in this PR, in particular adding proper tests.