Store helper proxies instead of raw view contexts #438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any time we want to use
Draper::ViewContext.current
to access helper methods, we create a helper proxy tosend
the helpers because things likehtml_escape
are private. Each decorator class gets its own statelessHelperProxy
This pull request changes this behaviour so that instead of having one proxy per decorator class, we create a proxy when we store the view context. All decorators then use this same helper proxy, which means that in tests we can do something like this
which is not currently possible because
helper
anddecorator.h
are different objects (#436).I also made
HelperProxy#method_missing
define a method on theHelperProxy
class so that future calls to the helper don't go throughmethod_missing
again, à la #89.