Clear ViewContext before specs instead of after #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By doing it before, we get sure that another type of spec (model, acceptance) does not leave ViewContext in a wrong context... drapergem#523
|
👍 |
|
Looks good to me :) |
|
Just waiting for the tests. |
steveklabnik
added a commit
that referenced
this pull request
May 28, 2013
Clear ViewContext before specs instead of after
|
More rbx weirdness, but looks good otherwise :( Thanks! |
|
The good news is that they've already fixed the Rubinius bug! I guess it should land on Travis next week. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doing it before, we get sure that another type of spec (model,
acceptance) does not leave ViewContext in a wrong context...
#523