-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: ActiveJob Integration and Documentation #817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/active-job-integration
@syguer I don't know if you are still interested in helping, but if you are, I'd appreciate a look at this when you get a chance. |
sure 😄 |
@codebycliff Sorry for late. Looks good! 😄 let(:post) { Post.create }
let(:decorated_post) { post.decorate }
subject { decorated_post.to_global_id }
it { is_expected.to eq post.to_global_id } This might be exaggerate spec. I respect your decision 👍 |
Thanks! |
Alexander-Senko
added a commit
to Alexander-Senko/draper
that referenced
this pull request
Feb 6, 2024
Implementing `Decorator.find` improves compatibility with Global ID and allows one to use decorated objects in jobs seamlessly. Improves drapergem#817.
This was referenced Feb 6, 2024
Alexander-Senko
added a commit
to Alexander-Senko/draper
that referenced
this pull request
Feb 6, 2024
Implementing `Decorator.find` improves compatibility with Global ID and allows one to use decorated objects in jobs seamlessly. Resolves drapergem#663. Improves drapergem#817.
Alexander-Senko
added a commit
to Alexander-Senko/draper
that referenced
this pull request
Aug 30, 2024
Implementing `Decorator.find` improves compatibility with Global ID and allows one to use decorated objects in jobs seamlessly. Resolves drapergem#663. Improves drapergem#817.
Alexander-Senko
added a commit
to Alexander-Senko/draper
that referenced
this pull request
Sep 1, 2024
Implementing `Decorator.find` improves compatibility with Global ID and allows one to use decorated objects in jobs seamlessly. Resolves drapergem#663. Improves drapergem#817.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes it so that decorators implement
GlobalID
so they can be passed to background jobs. While you can now pass a decorated object to a background job, it won't be decorated when it is deserialized. This may lead to some confusion, so it is documented in the README.Testing
Try to pass a decorated object to a background job and it should no longer throw
ActiveJob::SerializationError
.To-Dos
References